[PATCH] D71167: [Driver] Default to -momit-leaf-frame-pointer for AArch64

Fri Dec 13 10:06:32 PST 2019

MaskRay added subscribers: dyung, ychen.
MaskRay added a comment.

In D71167#1783298 <https://reviews.llvm.org/D71167#1783298>, @sdesmalen wrote:

> The patch looks structurally fine, but I'm missing the argumentation for changing the default and related, the history of why the default is to //not// omit the frame pointer on leaf functions.
>  Can you provide some insight here?

Honestly we probably don't need this change if the consistency with GCC regarding -momit-leaf-frame-pointer is not useful. I touched this function in D64294 <https://reviews.llvm.org/D64294> and I hoped isPS4CPU did not have the special rule (@dyung @ychen).

I can abondon this patch if you think it is unnecessary. We may only need D71168 <https://reviews.llvm.org/D71168>.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71167/new/

https://reviews.llvm.org/D71167