[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 13 07:47:40 PST 2019


sammccall marked an inline comment as done.
sammccall added a comment.

OK, I'm going to land this with some reservations. It's a mess, but the number of callsites isn't overwhelming.
I'd been hoping to get away with bias-right, but we keep getting complaints about this.
It's hard to find an approach that solves this, doesn't obviously break other things, and is close enough to what we do now.
Happy to revisit in future, would be nice to get rid of this wart.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71345/new/

https://reviews.llvm.org/D71345





More information about the cfe-commits mailing list