[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

Hal Finkel via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 12 16:02:09 PST 2019


hfinkel added a comment.

In D71241#1782668 <https://reviews.llvm.org/D71241#1782668>, @ABataev wrote:

>


...

>> While we talk a lot about what you think is bad about this solution it seems we ignore the problems in the current one. Let me summarize a few:
>> 
>> - Take https://godbolt.org/z/XCjQUA where the wrong function is called in the target region (because the "hack" to inject code in the wrong definition is not applicable).
> 
> No time for it, just short answers. No definition for the variant - no definition for the base.

Are the variants not permitted to be external functions?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71241/new/

https://reviews.llvm.org/D71241





More information about the cfe-commits mailing list