[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

Thu Dec 12 13:06:59 PST 2019

martong marked an inline comment as done.
martong added a comment.

> Are you going to add any tests in the following patches?

I don't have any tests for now, but in a later patch we can create them.

================
Comment at: clang/lib/AST/ASTImporter.cpp:8043
+
+  Error VisitFunctionTypeLoc(FunctionTypeLoc From) {
+    auto To = ToL.castAs<FunctionTypeLoc>();
----------------
a_sidorin wrote:
> Does this import interacts well with type loc import partially done at L3258 (VisitFunctionDecl)? Should we merge them?
I think we should check here whether the given ParmVarDecl had been imported previously and if yes then set that with `setParam`, otherwise it could be set to a nullptr. @balazske what do you think?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71018/new/

https://reviews.llvm.org/D71018