[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants
Johannes Doerfert via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Dec 12 12:09:44 PST 2019
jdoerfert added a comment.
>> In fact, the current solution will disregard the `used` attribute here and not emit the function, which is bad. The Sema solution will dispatch the right calls and honor the `used` attribute properly.
>
> Nope, the function is emitted but as an alias to the function with the correct assembler.
The function is marked as `used` but the current solution dies not emit it. That is plain wrong. Even if it was not marked as used but externally visible you cannot *not emit it*. The alias solution is simply not working.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71241/new/
https://reviews.llvm.org/D71241
More information about the cfe-commits
mailing list