[clang-tools-extra] 65996c3 - [clang-tidy] Use early returns to make the code easier to read and potentially run faster

[Alexander Kornienko via cfe-commits]

Author: Alexander Kornienko
Date: 2019-12-12T17:00:57+01:00
New Revision: 65996c302a4472e597780c99bd834f9bf8978712

URL: https://github.com/llvm/llvm-project/commit/65996c302a4472e597780c99bd834f9bf8978712
DIFF: https://github.com/llvm/llvm-project/commit/65996c302a4472e597780c99bd834f9bf8978712.diff

LOG: [clang-tidy] Use early returns to make the code easier to read and potentially run faster

Added: 
    

Modified: 
    clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp b/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp
index 5b78155cd546..e046023106bf 100644
--- a/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp
@@ -262,26 +262,25 @@ static bool matchesStyle(StringRef Name,
       llvm::Regex("^[a-z]([a-z0-9]*(_[A-Z])?)*"),
   };
 
-  bool Matches = true;
   if (Name.startswith(Style.Prefix))
     Name = Name.drop_front(Style.Prefix.size());
   else
-    Matches = false;
+    return false;
 
   if (Name.endswith(Style.Suffix))
     Name = Name.drop_back(Style.Suffix.size());
   else
-    Matches = false;
+    return false;
 
   // Ensure the name doesn't have any extra underscores beyond those specified
   // in the prefix and suffix.
   if (Name.startswith("_") || Name.endswith("_"))
-    Matches = false;
+    return false;
 
   if (Style.Case && !Matchers[static_cast<size_t>(*Style.Case)].match(Name))
-    Matches = false;
+    return false;
 
-  return Matches;
+  return true;
 }
 
 static std::string fixupWithCase(StringRef Name,