[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/FormattedStringTests.cpp:79
+      {
+          Test::PlainText,
+          "after",
----------------
sammccall wrote:
> I'd consider writing this as
> `[&] { Para.appendText("after"); }` to make it clearer what's being tested.
> 
> Are you sure the table test is clearer than straight-line code incrementally building the paragrap/asserting here?
this test was huge in the beginning and having a straight line of appends were making it really hard to reason with. but it seems leaner now, as it doesn't have codeblocks anymore.
switching back to linear testing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71248/new/

https://reviews.llvm.org/D71248