[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

Wed Dec 11 16:03:31 PST 2019

jdoerfert marked 2 inline comments as done.
jdoerfert added a comment.

In D70258#1780611 <https://reviews.llvm.org/D70258#1780611>, @ABataev wrote:

> Tests?

This changes the implementation and does not add features. Thus, this is covered by the existing tests for the functionality, e.g. the unit tests to build barriers and the front-end barrier test.

================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:51
+  /// at the time, and location, the callback is invoked.
+  using FinalizeCallbackTy = std::function<void(InsertPointTy /* CodeGenIP */)>;
+
----------------
ABataev wrote:
> `llvm::function_ref`?
The lambda that is passed in here might go out of scope so we need to own it. This is intentional.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70258/new/

https://reviews.llvm.org/D70258