[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert marked 2 inline comments as done.
jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:74
+///
+///{
+namespace types {
----------------
ABataev wrote:
> jdoerfert wrote:
> > ABataev wrote:
> > > Extra comments?
> > I don't know what you want to tell me.
> I mean, you have this `///{` here. Do you need it?
Yes, to help the doxygen documentation.


================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:174-177
+    if (auto *IdentI = dyn_cast<Instruction>(Ident))
+      Call->moveAfter(IdentI);
+    else
+      Call->moveBefore(&*Fn->getEntryBlock().getFirstInsertionPt());
----------------
ABataev wrote:
> jdoerfert wrote:
> > ABataev wrote:
> > > Are you sure it will work correctly with late outlining?
> > Yes.
> Ah, the code fro threadid changed already, probably missed it.
I removed the TODOs now, including the caching.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69785/new/

https://reviews.llvm.org/D69785