[PATCH] D71282: Fix bug 44190 - wrong code with #pragma pack(1)
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Dec 10 09:50:50 PST 2019
rjmccall added inline comments.
================
Comment at: clang/lib/CodeGen/CGCall.cpp:4008
+ if ((!ArgInfo.getIndirectByVal() ||
+ (LV.getAlignment() < getContext().getTypeAlignInChars(I->Ty)))) {
NeedCopy = true;
----------------
Thanks for the fix. Please remove all the unnecessary parens, but otherwise LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71282/new/
https://reviews.llvm.org/D71282
More information about the cfe-commits
mailing list