[PATCH] D71284: [clangd] Consider () part of the FunctionDecl, not the FunctionTypeLoc

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 10 09:41:44 PST 2019


sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.

CODE: int foo(int);
OLD:  TTT FFFTTTTT
NEW:  TTT FFFFTTTF

This works around targeting issues when the cursor is between name and (


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D71284

Files:
  clang-tools-extra/clangd/Selection.cpp
  clang-tools-extra/clangd/test/hover.test
  clang-tools-extra/clangd/unittests/SelectionTests.cpp
  clang-tools-extra/clangd/unittests/TweakTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71284.233130.patch
Type: text/x-patch
Size: 4593 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191210/5b9bf323/attachment.bin>


More information about the cfe-commits mailing list