[PATCH] D70157: Align branches within 32-Byte boundary

Fedor Sergeev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 10 06:02:21 PST 2019


fedor.sergeev added a comment.

In D70157#1776424 <https://reviews.llvm.org/D70157#1776424>, @skan wrote:

> > What if I insert explicit align(8) right *after* the sequence?
>
> If your insert explicit `.align 8` after the sequence, and the sequence doesn't has any branch to be aligned, the current solution won't change the sequence.


Well, I kinda figure that from the code behavior right now, however is it really by design or just happens to work now?
Seeing that assembler becomes very intelligent now I would rather have a strict guarantee similar to "hardcode" thing that you have here that protects my sequence
rather than relying on a fact that in current settings moving my label by 8 does not appear to be profitable to assembler.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70157/new/

https://reviews.llvm.org/D70157





More information about the cfe-commits mailing list