[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

[Artem Dergachev via Phabricator via cfe-commits]

NoQ added a comment.

It still mildly worries me that the attributes aren't truly reusable, as the exact meaning of the attribute depends on the domain. In particular, every domain is expected to have different approaches to error handling, i.e. a function that creates or destroys a handle may fail to, respectively, create or destroy the handle, but instead indicate the failure in a domain-specific manner, eg. through magical return values or null handle or errno or whatever.

@aaron.ballman, do you think this is a problem? Should we rather go for an attribute name that's obviously domain-specific (eg., `__attribute__((fuchsia_acquire_handle))`), or is it ok to re-use attributes without re-using their exact meaning?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70469/new/

https://reviews.llvm.org/D70469