[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

Sam Clegg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 9 17:11:01 PST 2019


sbc100 marked an inline comment as done.
sbc100 added inline comments.


================
Comment at: lld/test/wasm/export-name.ll:20
+; CHECK-NEXT:    Exports:
+; CHECK-NEXT:      - Name:            memory
+; CHECK-NEXT:        Kind:            MEMORY
----------------
dschuff wrote:
> does this test need to verify that the memory and _start are exported? seems like just a check for bar would be enough.
The worry that if I just look for ` Name:            bar` it might appear in some other section too mabye?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70520/new/

https://reviews.llvm.org/D70520





More information about the cfe-commits mailing list