[PATCH] D71208: CodeGen: Allow annotations on globals in non-zero address space

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 9 16:07:44 PST 2019


rjmccall added a comment.

The questions I'd like to have answered before I can approve this are:

- whether there are clients of `@llvm.global.annotations` that will have problems with non-0 address spaces and
- whether this will interfere with someday having an invariant that `addrspacecast` is only used to do legal conversions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71208/new/

https://reviews.llvm.org/D71208





More information about the cfe-commits mailing list