[PATCH] D71187: [clangd] Delete default arguments while moving functions out-of-line
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Dec 9 07:19:14 PST 2019
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:199
+ // Find the last `=` before the default arg.
+ for (auto &Tok : llvm::reverse(Tokens)) {
+ if (Tok.kind() != tok::equal)
----------------
nit: `llvm::find_if(llvm::reverse(Tokens), [](Tok) { return Toke.kind() == tok::equal; })`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71187/new/
https://reviews.llvm.org/D71187
More information about the cfe-commits
mailing list