[PATCH] D70594: [clangd] Implement range patching heuristics for cross-file rename.

[Haojian Wu via Phabricator via cfe-commits]

hokein updated this revision to Diff 232844.
hokein marked 12 inline comments as done.
hokein added a comment.

address comments:

- don't emit the internal messages to users, llvm::Expected => llvm::Optional
- use the index of lexed array to calculate the adjustment cost.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70594/new/

https://reviews.llvm.org/D70594

Files:
  clang-tools-extra/clangd/refactor/Rename.cpp
  clang-tools-extra/clangd/refactor/Rename.h
  clang-tools-extra/clangd/unittests/RenameTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70594.232844.patch
Type: text/x-patch
Size: 17403 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191209/48939eb5/attachment-0001.bin>