[PATCH] D71189: [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.

[Sam McCall via Phabricator via cfe-commits]

sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, ilya-biryukov, mgorny.
Herald added a project: clang.
sammccall updated this revision to Diff 232791.
sammccall added a comment.

revert random meaningless changes


Instead, emit a diagnostic and return an empty ASM node, as we do if the target
is missing.

Filter this diagnostic out in clangd, where it's not meaningful.

Fixes https://github.com/clangd/clangd/issues/222


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D71189

Files:
  clang-tools-extra/clangd/Diagnostics.cpp
  clang-tools-extra/clangd/unittests/CMakeLists.txt
  clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
  clang/lib/Parse/ParseStmtAsm.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71189.232791.patch
Type: text/x-patch
Size: 4773 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191209/709f64cc/attachment-0001.bin>