[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

[Aleksei Sidorin via Phabricator via cfe-commits]

a_sidorin added a comment.

Finally, this FIXME is addressed. Thanks! Are you going to add any tests in the following patches?
It looks almost good to me, but I have a question inline.



================
Comment at: clang/lib/AST/ASTImporter.cpp:7914
+
+#define IMPORT_TYPE_LOC(NAME)                                                  \
+  if (auto ImpOrErr = Importer.Import(From.get##NAME()))                       \
----------------
IMPORT_TYPE_LOC_ELEMENT_OR_RETURN_ERROR.


================
Comment at: clang/lib/AST/ASTImporter.cpp:8043
+
+  Error VisitFunctionTypeLoc(FunctionTypeLoc From) {
+    auto To = ToL.castAs<FunctionTypeLoc>();
----------------
Does this import interacts well with type loc import partially done at L3258 (VisitFunctionDecl)? Should we merge them?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71018/new/

https://reviews.llvm.org/D71018