[PATCH] D71141: [Wdocumentation] Use C++14 deprecated attribute

[Mark de Wever via Phabricator via cfe-commits]

Mordante marked 3 inline comments as done.
Mordante added inline comments.


================
Comment at: clang/lib/AST/CommentSema.cpp:693
+    StringRef AttributeSpelling =
+        CPlusPlus14 ? "[[deprecated]]" : "__attribute__((deprecated))";
     if (PP) {
----------------
Mordante wrote:
> aaron.ballman wrote:
> > Mordante wrote:
> > > aaron.ballman wrote:
> > > > This attribute also exists with this spelling in C2x, FWIW.
> > > True, but unless I'm mistaken `CPlusPlus17` and `CPlusPlus2a` also include `CPlusPlus14`. Do you prefer a different name for the Boolean?
> > I'm talking about C2x, not C++2a. The name for the variable is fine, but we should prefer `[[deprecated]]` in C2x mode to `__attribute__((deprecated))`.
> > 
> > I think the correct predicate is: `getLangOpts().DoubleSquareBracketAttributes` -- if the user says they want to use double-square bracket attributes, we should probably prefer them to GNU-style attributes.
> Ah sorry I misread. I'll have a look at C2x. Thanks for the information.
`getLangOpts().DoubleSquareBracketAttributes` will not work since it includes C++11, which doesn't support `[[deprecated]]`, so I will just test for C++14 and C2x.
(I had a look at the proper syntax in C2x and found N2334 ;-))


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71141/new/

https://reviews.llvm.org/D71141