[PATCH] D71154: Driver: Don't look for libc++ headers in the install directory on Android.

Dan Albert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 6 16:53:11 PST 2019


danalbert requested changes to this revision.
danalbert added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang/test/Driver/android-no-installed-libcxx.cpp:8
+// RUN:   -stdlib=libc++ -fsyntax-only %s -### 2>&1 | FileCheck %s
+// CHECK-NOT: "-internal-isystem" "{{.*}}v1"
----------------
This looks like it should be failing. The NDK headers are installed to `<NDK>/sysroot/usr/include/c++/v1`. Presumably it's passing because the trivial sysroot in the test directory is not complete enough?

Will need a more specific CHECK-NOT here, and also a CHECK to make sure the correct directory is being searched.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71154/new/

https://reviews.llvm.org/D71154





More information about the cfe-commits mailing list