[PATCH] D71154: Driver: Don't look for libc++ headers in the install directory on Android.

Peter Collingbourne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 6 16:07:30 PST 2019


pcc created this revision.
pcc added reviewers: danalbert, srhines.
Herald added a reviewer: EricWF.
Herald added a subscriber: ldionne.
Herald added a project: clang.

The NDK uses a separate set of libc++ headers in the sysroot. Any headers
in the installation directory are not going to work on Android, not least
because they use a different name for the inline namespace (std::__1 instead
of std::__ndk1).

This effectively makes it impossible to produce a single toolchain that is
capable of targeting both Android and another platform that expects libc++
headers to be installed in the installation directory, such as Mac.

In order to allow this scenario to work, stop looking for headers in the
install directory on Android.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D71154

Files:
  clang/lib/Driver/ToolChains/Linux.cpp
  clang/test/Driver/android-no-installed-libcxx.cpp
  clang/test/Driver/stdlibxx-isystem.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71154.232670.patch
Type: text/x-patch
Size: 5149 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191207/2f04c5b7/attachment.bin>


More information about the cfe-commits mailing list