[PATCH] D68627: [Sema][X86] Consider target attribute into the checks in validateOutputSize and validateInputSize.
Reid Kleckner via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Dec 6 15:48:36 PST 2019
rnk added inline comments.
================
Comment at: clang/include/clang/AST/ASTContext.h:2826
+ /// valid feature names.
+ TargetAttr::ParsedTargetAttr
+ filterFunctionTargetAttrs(const TargetAttr *TD) const;
----------------
I reverted this because it requires TargetAttr to be complete here, which I have been working for a few weeks to avoid. If you pull ParsedTargetAttr out of the TargetAttr class, then you can forward declare it, and reland. Sorry I didn't see that in review, this commit raced with rG60573ae6fe509b618dc6a2c5c55d921bccd77608, which removes the Attr.h include in ASTContext.h.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68627/new/
https://reviews.llvm.org/D68627
More information about the cfe-commits
mailing list