[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

Fri Dec 6 13:39:10 PST 2019

MadCoder added inline comments.

================
Comment at: clang/lib/Sema/SemaDeclObjC.cpp:4839

+  ObjCMethod->createImplicitParams(Context, ObjCMethod->getClassInterface());
+
----------------
MadCoder wrote:
> liuliu wrote:
> > Yeah, I applied this change. As I said, for my trivial example it does work. But for my more thorough example with @property (direct) etc, it doesn't. I can dig into more later today or Monday. I just got everything work (with another more hackier fix) and would first to evaluate this as a viable path first before commit more time to debug this.
> > 
> > We probably can also just have a follow-up fix for that, depends on if reviewers thought this is blocking or not. I personally think not.
> Huh I could have seen why property methods would have an issue but they seem to have gotten their `direct`ness properly anyway (I'll add them to the CG test for good measure while I debug the tests I broke).
> 
> so I'll need a reduced test case from you I can't seem to find an easy way to break it indeed.
I just added a test using a direct property with both a synthesized and a manual one, and it seems to work for me (?)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71091/new/

https://reviews.llvm.org/D71091