[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

Fri Dec 6 12:34:01 PST 2019

aaron.ballman added a comment.

In D71005#1773042 <https://reviews.llvm.org/D71005#1773042>, @bader wrote:

> @aaron.ballman, thank you for fixing the problem with documentation generation.

No problem!

> With regards to attributes naming question, let me check if I get it right.
> 
> 1. You suggest checking with Khronos if they want to adopt `[[opencl::private]]` attribute names in OpenCL kernel language standard. Right? @Anastasia, can you help with this?

That's correct.

> 2. If Khronos leaves this decision to implementers, are current names (e.g. `[[clang::opencl_private]]`) look okay or we should consider other options?

If they want to leave it to implementers, I think the names you have now are fine.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71005/new/

https://reviews.llvm.org/D71005