[PATCH] D71141: [Wdocumentation] Use C++14 deprecated attribute

Mark de Wever via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 6 12:25:39 PST 2019


Mordante marked an inline comment as done.
Mordante added inline comments.


================
Comment at: clang/lib/AST/CommentSema.cpp:693
+    StringRef AttributeSpelling =
+        CPlusPlus14 ? "[[deprecated]]" : "__attribute__((deprecated))";
     if (PP) {
----------------
aaron.ballman wrote:
> This attribute also exists with this spelling in C2x, FWIW.
True, but unless I'm mistaken `CPlusPlus17` and `CPlusPlus2a` also include `CPlusPlus14`. Do you prefer a different name for the Boolean?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71141/new/

https://reviews.llvm.org/D71141





More information about the cfe-commits mailing list