[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

JF Bastien via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 6 09:08:55 PST 2019


jfb added a comment.

You should upload patches with context :)



================
Comment at: clang/lib/CodeGen/CGObjCMac.cpp:4030
                                       const ObjCContainerDecl *CD) {
-  auto I = DirectMethodDefinitions.find(OMD);
+  auto I = DirectMethodDefinitions.find(OMD->getCanonicalDecl());
   if (I != DirectMethodDefinitions.end())
----------------
I'd rather have `auto *` or `Decl *` here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71091/new/

https://reviews.llvm.org/D71091





More information about the cfe-commits mailing list