[PATCH] D70439: [Analyzer][Docs][NFC] Add CodeChecker to the command line tools

Fri Dec 6 06:03:12 PST 2019

martong marked 6 inline comments as done.
martong added a comment.

In D70439#1772168 <https://reviews.llvm.org/D70439#1772168>, @Charusso wrote:

> I would change the order of CCh and scan-build because we usually list stuff in alphabetical order. Also the chronological order is that, the newest is the first.

I am not sure if the order matters that much  because the page is very terse and small, so a reader can have a quick look to see that there are only these tools.

================
Comment at: clang/www/analyzer/codechecker.html:13
+<div id="page">
+<!--#include virtual="menu.html.incl"-->
+<div id="content">
----------------
NoQ wrote:
> martong wrote:
> > NoQ wrote:
> > > Note related to your patch, but SSI seem to be completely broken these days; previously the dropdown menus header kept working on the front page but now even that's missing. Patches are very welcome >.<
> > Ok, actually, this line is a result of copy pasting from scan-build.html. I don't think I'd be competence enough to solve the drop-down menu issue, so, I just removed this line.
> No-no, i'd rather keep it. Otherwise how do we remember to fix it? :D
Alright, I've put it back.

================
Comment at: clang/www/analyzer/codechecker.html:48
+CodeChecker parse ./reports -e html -o ./reports_html
+firefox ./reports_html/index.html
+</pre>
----------------
NoQ wrote:
> Maybe `xdg-open`?
I'd like to keep "firefox" so readers immediately know that we are dealing with a web-browser. "xdg-open" might not be that obvious I think.

================
Comment at: clang/www/analyzer/command-line.html:54
+    <li>Can run clang-tidy checkers too.</li>
+    <li>Out-of-tree, not part of the LLVM project.</li>
+  </ul>
----------------
Charusso wrote:
> LLVM peoples seems to care to use open source projects, so I would mention it.
Ok, I added that to this list item.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70439/new/

https://reviews.llvm.org/D70439