[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 6 05:43:36 PST 2019


martong added a comment.

Thanks for addressing this, I just have some minor comments.



================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:5603
+TEST_P(ASTImporterOptionSpecificTestBase, ImplicitlyDeclareSelf) {
+  Decl *FromTU = getTuDecl("__attribute__((objc_root_class))\n"
+                           "@interface Root\n"
----------------
You could use a raw string literal for the code, that way we could get rid of the '\n's and the trailing " characters.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71112/new/

https://reviews.llvm.org/D71112





More information about the cfe-commits mailing list