[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

Thu Dec 5 15:12:59 PST 2019

mstorsjo added a comment.

In D69950#1771515 <https://reviews.llvm.org/D69950#1771515>, @rnk wrote:

> I fixed this particular code upstream:
>  https://github.com/KhronosGroup/glslang/pull/2010
>  I am not enough an expert to be sure, but I suspect this is in the area of "invalid, no diagnostic required", where this code is invalid, but a conforming C++ implementation could either reject or accept it. Now we reject it, and that seems better in the long term, even though it creates a fire drill in the short term. =(

Ok, thanks for the input! I'll go cherrypick that fix then.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69950/new/

https://reviews.llvm.org/D69950