[PATCH] D71042: [DebugInfo] Ensure fallback artificial location is available for cleanups

Vedant Kumar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 5 12:36:12 PST 2019


vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.

Thanks, lgtm with a minor change.



================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:384
+      else
+        assert(EndLoc.isValid() && "no location for inlineable cleanup calls");
+    }
----------------
The braces around the `else` block are probably needed in the NDEBUG build.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71042/new/

https://reviews.llvm.org/D71042





More information about the cfe-commits mailing list