[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 5 12:17:09 PST 2019


aaron.ballman added a comment.

In D71005#1771513 <https://reviews.llvm.org/D71005#1771513>, @saugustine wrote:

> When I try to run tablegen on this file for clang/docs (as described in clang/docs/InternalsManual.rst), I get an error, introduced by this change:
>
> $ ./bin/clang-tblgen -gen-attr-docs -I ../llvm-project/clang/include ../llvm-project/clang/include/clang/Basic/Attr.td -o /tmp/AttributeReference.rst
>
> ../llvm-project/clang/include/clang/Basic/Attr.td:1137:1: error: This attribute requires a heading to be specified
>  def OpenCLConstantAddressSpace : TypeAttr {
>  ^
>
> I'm at a loss as to what is wrong, but I would like to revert this change until it is fixed.


This should be fixed in f5193d87feaedb411255e92979abd6b62522bc38 <https://reviews.llvm.org/rGf5193d87feaedb411255e92979abd6b62522bc38> now, thank you for pointing it out!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71005/new/

https://reviews.llvm.org/D71005





More information about the cfe-commits mailing list