[PATCH] D71042: [DebugInfo] Ensure fallback artificial location is available for cleanups

Vedant Kumar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 5 09:57:04 PST 2019


vsk added a comment.

In D71042#1771040 <https://reviews.llvm.org/D71042#1771040>, @aprantl wrote:

> This will definitely work; Once you got the testcase, it might be good to check whether there is a more targeted root cause that we could fix and assert on EndLoc here.


I believe the root cause is that GenerateObjCSetter does not pass a valid EndLoc, and does not have a 'simple' return statement. That seems reasonable to me, after all FinishFunction() defaults EndLoc to an invalid location, and there is no explicit return statement for an ObjC setter in source.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71042/new/

https://reviews.llvm.org/D71042





More information about the cfe-commits mailing list