[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 5 05:53:05 PST 2019


thakis added a comment.

Why do we emit this before C++20? It's only deprecated in C++20 onwards, no? Shouldn't this be default-enabled based off language version instead of being in -Wextra? No other language deprecation warning so far (register etc) has worked like this warning does.

(Also, this being in -Wextra has confused users for us: We added -Wno-deprecated-copy somewhere in our central build flags, and then some target added -Wextra later on and was confused that the -Wno-deprecated-copy flag didn't have an effect – but that's a minor point.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70342/new/

https://reviews.llvm.org/D70342





More information about the cfe-commits mailing list