[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Wed Dec 4 22:45:13 PST 2019

nathanchance added a comment.

> IMO that is misleading indentation. A single space followed by a tab? WTF

I guess I will take a look over all of the warnings that cropped up and see if this is the case for all of them. If it is, I will just send patches to fix those (with the justification of the warning and the fact that it would be a checkpatch warning), rather than adding `-ftabstop` to `KBUILD_CFLAGS`.

  $ ./scripts/checkpatch.pl --terse --types LEADING_SPACE -f drivers/video/fbdev/core/fbmem.c
  drivers/video/fbdev/core/fbmem.c:665: WARNING: please, no spaces at the start of a line
  drivers/video/fbdev/core/fbmem.c:666: WARNING: please, no spaces at the start of a line
  drivers/video/fbdev/core/fbmem.c:667: WARNING: please, no spaces at the start of a line
  drivers/video/fbdev/core/fbmem.c:668: WARNING: please, no spaces at the start of a line
  drivers/video/fbdev/core/fbmem.c:669: WARNING: please, no spaces at the start of a line
  drivers/video/fbdev/core/fbmem.c:670: WARNING: please, no spaces at the start of a line
  drivers/video/fbdev/core/fbmem.c:671: WARNING: please, no spaces at the start of a line
  drivers/video/fbdev/core/fbmem.c:672: WARNING: please, no spaces at the start of a line
  drivers/video/fbdev/core/fbmem.c:673: WARNING: please, no spaces at the start of a line
  drivers/video/fbdev/core/fbmem.c:674: WARNING: please, no spaces at the start of a line
  drivers/video/fbdev/core/fbmem.c:675: WARNING: please, no spaces at the start of a line
  drivers/video/fbdev/core/fbmem.c:676: WARNING: please, no spaces at the start of a line
  drivers/video/fbdev/core/fbmem.c:677: WARNING: please, no spaces at the start of a line
  drivers/video/fbdev/core/fbmem.c:678: WARNING: please, no spaces at the start of a line
  drivers/video/fbdev/core/fbmem.c:1063: WARNING: please, no spaces at the start of a line
  drivers/video/fbdev/core/fbmem.c:1064: WARNING: please, no spaces at the start of a line
  drivers/video/fbdev/core/fbmem.c:1070: WARNING: please, no spaces at the start of a line
  drivers/video/fbdev/core/fbmem.c:1075: WARNING: please, no spaces at the start of a line

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70638/new/

https://reviews.llvm.org/D70638