[PATCH] D67463: [MS] Warn when shadowing template parameters under -fms-compatibility

Wed Dec 4 14:10:35 PST 2019

tstellar added a comment.

In D67463#1769557 <https://reviews.llvm.org/D67463#1769557>, @rnk wrote:

> In D67463#1769238 <https://reviews.llvm.org/D67463#1769238>, @tstellar wrote:
>
> > In D67463#1767919 <https://reviews.llvm.org/D67463#1767919>, @rnk wrote:
> >
> > > @hans, are we still accepting 9.0.1 patches? I thought we'd already made a release candidate.
> >
> >
> > I'm still accepting patches until rc2 (which should have been Monday, but was delayed), so I can pull it if you think it is important.
>
>
> You know, it's a significant change in behavior. This will cause hard errors for users of `-fms-extensions` who do not use `-fms-compatibility`. Maybe it's better to release that changes in the 10.0 release.

Ok, we'll leave it out.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67463/new/

https://reviews.llvm.org/D67463