[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 4 12:26:08 PST 2019


erichkeane added a comment.

In D62731#1769532 <https://reviews.llvm.org/D62731#1769532>, @thakis wrote:

> The tests fail on Windows, http://45.33.8.238/win/3405/step_6.txt
>
> Please take a look, and if it takes a while to fix please revert while you investigte.


It appears that only the 1st failure there is the fault of this patch.  The 2nd seems to have come from some openmp patch (that didn't consider dso_local on windows).

The first (fpconstrained.cpp) likely just needs the check-lines to NOT explicitly say the %4/%5 and capture the loads of those with a wildcard instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62731/new/

https://reviews.llvm.org/D62731





More information about the cfe-commits mailing list