[PATCH] D70764: build: reduce CMake handling for zlib

Jonas Devlieghere via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 4 11:28:06 PST 2019


JDevlieghere added a comment.

In D70764#1767413 <https://reviews.llvm.org/D70764#1767413>, @compnerd wrote:

> In D70764#1767395 <https://reviews.llvm.org/D70764#1767395>, @JDevlieghere wrote:
>
> > Having one canonical variable controlling zlib support seems indeed desirable.
> >
> > In D70519#1754618 <https://reviews.llvm.org/D70519#1754618>, @labath wrote:
> >
> > > With this patch, what is the output of `llvm-config --system-libs` ?
> >
> >
> > @compnerd What's the answer to this for this patch?
>
>
> Sorry, didn't see the question.  From my local build:
>
>    $ ./bin/llvm-config --system-libs
>   /usr/lib/x86_64-linux-gnu/libz.so -lrt -ldl -ltinfo -lpthread -lm /usr/lib/x86_64-linux-gnu/libxml2.so
>


So that's the issue Pavel raised in the other review. Can we make this return `-lz` with the current approach?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70764/new/

https://reviews.llvm.org/D70764





More information about the cfe-commits mailing list