[PATCH] D70974: [clang-tidy] Fix PR26274
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Dec 4 11:18:18 PST 2019
aaron.ballman added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp:79
+ } else { // Any other kind of token is unexpected here.
+ return llvm::None;
+ }
----------------
How well do these test cases work?
```
namespace [[]] {
}
namespace frobble::inline bar {
}
```
I'm not certain what we want the comment to be for the second example, and I'm not certain the first example will parse properly here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70974/new/
https://reviews.llvm.org/D70974
More information about the cfe-commits
mailing list