[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

[Sam McCall via Phabricator via cfe-commits]

sammccall created this revision.
sammccall added reviewers: kbobyrev, ilya-biryukov.
sammccall added a project: clang.
Herald added subscribers: ormris, mgorny.

This was originally committed in 88bccded8fa169481fa367debf5ec615640635a1 <https://reviews.llvm.org/rG88bccded8fa169481fa367debf5ec615640635a1>,
and reverted in 93f77617abba512d2861e2fc50ce385883f587b6 <https://reviews.llvm.org/rG93f77617abba512d2861e2fc50ce385883f587b6>.

This version is now much more testable: the "detect toolchain properties" part
is still not tested but also not active in tests.
All the command manipulation based on the detected properties is
directly tested, and also not active in other tests.

Fixes https://github.com/clangd/clangd/issues/211
Fixes https://github.com/clangd/clangd/issues/178


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D71029

Files:
  clang-tools-extra/clangd/CMakeLists.txt
  clang-tools-extra/clangd/ClangdLSPServer.cpp
  clang-tools-extra/clangd/CompileCommands.cpp
  clang-tools-extra/clangd/CompileCommands.h
  clang-tools-extra/clangd/GlobalCompilationDatabase.cpp
  clang-tools-extra/clangd/GlobalCompilationDatabase.h
  clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp
  clang-tools-extra/clangd/unittests/CMakeLists.txt
  clang-tools-extra/clangd/unittests/ClangdTests.cpp
  clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp
  clang-tools-extra/clangd/unittests/GlobalCompilationDatabaseTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71029.232181.patch
Type: text/x-patch
Size: 27644 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191204/8557212f/attachment-0001.bin>