[PATCH] D70987: [AMDGPU][HIP] Improve opt-level handling

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 4 08:17:56 PST 2019


yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang/lib/Driver/ToolChains/HIP.cpp:153
+  // Pass optimization arg to llc.
+  addOptLevelArgs(Args, LlcArgs, true);
+  LlcArgs.push_back("-mtriple=amdgcn-amd-amdhsa");
----------------
Please add /*IsLlc=*/ before true


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70987/new/

https://reviews.llvm.org/D70987





More information about the cfe-commits mailing list