[PATCH] D70489: [clangd] Add xref for macro to static index.

UTKARSH SAXENA via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 4 06:53:22 PST 2019


usaxena95 added inline comments.


================
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:472
   }
-  if (Opts.CollectMacro) {
-    assert(PP);
----------------
hokein wrote:
> hokein wrote:
> > this code should not be modified, since we don't use the `CollectMacro` option.
> this comment seems undone yet.
I moved the Collecting references for Macros out of the if. This part of code just seems to be moved. 
It's now moved to the original place.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70489/new/

https://reviews.llvm.org/D70489





More information about the cfe-commits mailing list