[PATCH] D70489: [clangd] Add xref for macro to static index.

[Haojian Wu via Phabricator via cfe-commits]

hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:472
   }
-  if (Opts.CollectMacro) {
-    assert(PP);
----------------
hokein wrote:
> this code should not be modified, since we don't use the `CollectMacro` option.
this comment seems undone yet.


================
Comment at: clang-tools-extra/clangd/indexer/IndexerMain.cpp:45
     Opts.CountReferences = true;
+    Opts.CollectMacro = true;
     return createStaticIndexingAction(
----------------
I think this change is unintended?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70489/new/

https://reviews.llvm.org/D70489