[PATCH] D70854: [Clang] In tests, do not always assume others permissions are set

[Alexandre Ganea via Phabricator via cfe-commits]

aganea updated this revision to Diff 232100.
aganea marked an inline comment as done.
aganea added subscribers: tstellar, Meinersbur.
aganea added a comment.

Just after I hit Submit last night, I found a better way, by disabling ACL for that folder.
Ping @tstellar @Meinersbur in case they have an opinion.
Please let me know which solution you think is better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70854/new/

https://reviews.llvm.org/D70854

Files:
  clang/test/Misc/permissions.cpp


Index: clang/test/Misc/permissions.cpp
===================================================================
--- clang/test/Misc/permissions.cpp
+++ clang/test/Misc/permissions.cpp
@@ -1,5 +1,9 @@
 // REQUIRES: shell
 
+// Disable ACL for the output folder, otherwise umask below will have no effect.
+// RUN: setfacl -bn %T
+// RUN: chmod -R o+rx %T
+
 // RUN: umask 000
 // RUN: %clang_cc1 -emit-llvm-bc %s -o %t
 // RUN: ls -l %t | FileCheck --check-prefix=CHECK000 %s


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70854.232100.patch
Type: text/x-patch
Size: 470 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191204/903b503a/attachment.bin>