[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 4 05:57:19 PST 2019


sammccall added a comment.

In D69764#1768420 <https://reviews.llvm.org/D69764#1768420>, @MyDeveloperDay wrote:

> As a consensus how about I drop Before/After and Keep Left/Right and West/East const support? (as no one is asking for Before/After?) can we handle having 2 options to aid language issues?


FWIW as a non-US person (but english speaker) my preferences would be:

1. east/west (this is what the community uses AFAICT)
2. left/right
3. both as synonyms

I don't think synonyms buy much, people who don't understand "west" will still have to work on projects where the config says "west".
And printing the config will use a different label, which is mildly confusing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69764/new/

https://reviews.llvm.org/D69764





More information about the cfe-commits mailing list