[PATCH] D70905: Actually delay processing DelayedDllExportClasses until the outermost class is finished (PR40006)
Hans Wennborg via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Dec 4 04:25:09 PST 2019
hans marked 2 inline comments as done.
hans added a comment.
Thanks for the review!
================
Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2232
+ if (ParsingClassDepth == 0)
+ ActOnFinishCXXNonNestedClass(Instantiation);
----------------
rnk wrote:
> This function doesn't use its argument. Can you remove it so that is clear that we don't need to track this somewhere else?
Done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70905/new/
https://reviews.llvm.org/D70905
More information about the cfe-commits
mailing list