[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 4 00:54:00 PST 2019


MyDeveloperDay added a comment.

so now I think this is better because it's encased inside your TT_ObjCMethodExpr method which means it should only impact ObjectiveC

Nit on the documentation 
Nit missing parse tests

but otherwise you are pretty close, make those changes and I'll mark accepted



================
Comment at: clang/docs/ReleaseNotes.rst:343
+
+  .. code-block:: c++
+
----------------
Nit: this section should really go into the Format.h and the ClangFormatStyle.rst, for the release note a couple of lines is probably ample.

But ultimately this example will disappear from the release notes (as they move on) and I think this example is good to have in the main documentation.




================
Comment at: clang/unittests/Format/FormatTest.cpp:14446
 }
 
+TEST_F(FormatTest, DoNotBreakLineBeforeNestedBlockParam) {
----------------
Nit: you are missing a CHECK_PARSE_BOOL tests


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70926/new/

https://reviews.llvm.org/D70926





More information about the cfe-commits mailing list