[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun added a comment.

In D70725#1767673 <https://reviews.llvm.org/D70725#1767673>, @NoQ wrote:

> In D70725#1767643 <https://reviews.llvm.org/D70725#1767643>, @Charusso wrote:
>
> > In D70725#1767579 <https://reviews.llvm.org/D70725#1767579>, @xazax.hun wrote:
> >
> > > Just a small side note. If the state was same as the previous we do not end up creating a new ExplodedNode right? Is this also the case when we add a NoteTag?
> >
> >
> > It only happens for evaluation when you cannot evaluate something. Other than that `Pre/PostCall` working fine to add a node with the `NoteTag`.
>
>
> Tag pointers are part of the `ProgramPoint`'s identity, which in turn are part of the `ExplodedNode`'s identity. If you make a new note tag and transition into it for the first time, the new node is guaranteed to be fresh.


This is what I suspected. I wonder if all the checks end up using NoteTags will the increased number of nodes will ever be a concern? Maybe if is the same as the previous we should just omit the note tag?

For example, my checker before the note tag would only generate new nodes if there was an actual change to the state. After this change it probably ends up adding new nodes with empty note tags all the time.  This could be bad both for performance and debugging. What do you think?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70725/new/

https://reviews.llvm.org/D70725