[PATCH] D70974: [clang-tidy] Fix PR26274

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

Thank you for working on this!



================
Comment at: clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp:55
 
-  if (!locationsInSameFile(Sources, ND->getBeginLoc(), ND->getRBraceLoc()))
+  // Ignore namespaces inside macros and namespaces split accross files.
+  if (ND->getBeginLoc().isMacroID() ||
----------------
accross -> across


================
Comment at: clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp:90
+    } else {
+      break;
     }
----------------
Will this work okay with inline namespaces, or namespaces with attributes written on them? May want test cases for those situations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70974/new/

https://reviews.llvm.org/D70974