[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 2 19:47:09 PST 2019


rjmccall added a comment.

I can't speak for the pragma authors, but I strongly doubt the pragma is intended to force all affected globals to go into a single section unit, since the division into section units is purely an object-file representation issue.

Looks to me like `MCContext::getELFSection` should be including the entry size and flags as part of the uniquing key.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68101/new/

https://reviews.llvm.org/D68101





More information about the cfe-commits mailing list